fix: create the first persistent artifact on the incremental path#1163
Open
mvanhorn wants to merge 2 commits into
Open
fix: create the first persistent artifact on the incremental path#1163mvanhorn wants to merge 2 commits into
mvanhorn wants to merge 2 commits into
Conversation
…is created Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Owner
|
Thanks for covering both changed-file and no-op incremental paths and for propagating export failure rather than reporting a false success. This is classified with #434 as a 0.9.1-rc bug fix. Review will verify explicit persistence versus automatic refresh semantics, first-export quality selection, artifact failure behavior, and compatibility with the existing incremental artifact stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #434: enabling
persistence=truedid not create the first persistent artifact on the incremental indexing path.dump_and_persistinpipeline_incremental.conly refreshed an artifact that already existed and never created one on first run, so apersistence=truerequest was silently a no-op until an artifact happened to exist.git ai stats-style consumers saw the index reported as successful with no persistent artifact written.This threads a new
cbm_pipeline_persistence()accessor into the incremental path (mirroring the existingcbm_pipeline_repo_path/cbm_pipeline_project_nameaccessors) so it exports the first artifact withCBM_ARTIFACT_BESTwhen persistence is requested and none exists, matching the full pipeline. Existing artifacts keep refreshing withCBM_ARTIFACT_FAST. It covers changed-file, deleted-file, and no-op incremental runs, and it now propagates a failedcbm_artifact_exportas a run error instead of reporting a successful index when the artifact could not be written.Checklist
git commit -s) — required, CI rejects unsigned commits (DCO, see CONTRIBUTING.md)make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)